core+gui: timezone-correct datetimes, deep-copy WillItem, dead code removal, explicit imports

bal/gui/qt/calendar.py

@@ -13,12 +13,16 @@ The pure RFC-5545 logic (offsets, escaping, folding, the unified .ics builder,
 the Qt button and the OS/subprocess glue.
 """
 
+import os
+import subprocess
+
 from PyQt6.QtGui import QAction
-from PyQt6.QtWidgets import QToolButton
+from PyQt6.QtWidgets import QInputDialog, QMenu, QToolButton
+
+from electrum.gui.qt.util import getSaveFileName
 
 from ...core.reminders import write_temp_ics
-from .common import *
-from .common import _, _logger  # underscore names are not re-exported by "import *"
+from .common import _, _logger
 
 
 class BalCalendarButton(QToolButton):

bal/gui/qt/dialogs.py

@@ -22,8 +22,61 @@ from typing import TYPE_CHECKING
 from ...core.checkalive import CheckAliveError
 from ...core.reminders import build_ics_reminders
 from .calendar import BalCalendarButton
-from .common import *
-from .common import _, _logger  # underscore names are not re-exported by "import *"
+from .common import (
+    _,
+    _logger,
+    AmountException,
+    Any,
+    BalTimestamp,
+    BestEffortRequestFailed,
+    Buttons,
+    Callable,
+    CancelButton,
+    HEIR_DUST_AMOUNT,
+    HEIR_REAL_AMOUNT,
+    HeirAmountIsDustException,
+    HeirChangeException,
+    HeirNotFoundException,
+    MessageBoxMixin,
+    Network,
+    NoHeirsException,
+    NoWillExecutorNotPresent,
+    NotCompleteWillException,
+    QComboBox,
+    QDialog,
+    QHBoxLayout,
+    QLabel,
+    QPushButton,
+    QScrollArea,
+    QSizePolicy,
+    QTimer,
+    QVBoxLayout,
+    QWidget,
+    Qt,
+    TaskThread,
+    TxBroadcastError,
+    TxFeesChangedException,
+    Util,
+    Will,
+    WillExecutorFeeTooHighException,
+    WillExecutorNotPresent,
+    WillExpiredException,
+    WillPostponedException,
+    WillexecutorChangeException,
+    Willexecutors,
+    bring_to_front,
+    decimal_point_to_base_unit_name,
+    import_meta_gui,
+    partial,
+    pyqtSignal,
+    read_QIcon_from_bytes,
+    read_json_file,
+    show_modal,
+    show_on_top,
+    stop_thread,
+    time,
+    top_level_of,
+)
 from .widgets import (
     WillSettingsWidget,
     WillWidget,

bal/gui/qt/lists.py

@@ -19,8 +19,59 @@ from typing import TYPE_CHECKING
 from PyQt6.QtWidgets import QLineEdit as _QLineEdit
 from PyQt6.QtWidgets import QMessageBox, QStyledItemDelegate
 
-from .common import *
-from .common import _, _logger  # underscore names are not re-exported by "import *"
+from .common import (
+    _,
+    _logger,
+    BalTimestamp,
+    Buttons,
+    CancelButton,
+    HelpButton,
+    MessageBoxMixin,
+    MyTreeView,
+    OP_RETURN_PREFIX,
+    OkButton,
+    QAbstractItemView,
+    QApplication,
+    QColor,
+    QGridLayout,
+    QHBoxLayout,
+    QLabel,
+    QLineEdit,
+    QMenu,
+    QModelIndex,
+    QPersistentModelIndex,
+    QPushButton,
+    QSize,
+    QSizePolicy,
+    QSpinBox,
+    QStandardItem,
+    QStandardItemModel,
+    QToolButton,
+    QVBoxLayout,
+    QWidget,
+    Qt,
+    TaskThread,
+    Util,
+    Will,
+    WillItem,
+    Willexecutors,
+    char_width_in_lineedit,
+    datetime,
+    enum,
+    export_meta_gui,
+    getOpenFileName,
+    import_meta_gui,
+    is_op_return_address,
+    partial,
+    read_QIcon_from_bytes,
+    read_json_file,
+    server_status_text,
+    server_status_tooltip,
+    signature_suffix,
+    status_color,
+    tx_from_any,
+    write_json_file,
+)
 from .dialogs import BalBuildWillDialog, BalDialog
 from .widgets import BalCheckBox, WillSettingsWidget
 

bal/gui/qt/plugin.py

@@ -15,14 +15,35 @@ and cached in ``self.bal_windows``.
 """
 
 from electrum.gui.qt.main_window import StatusBarButton
+from electrum.plugin import hook
 from electrum.util import EventListener, event_listener
 from PyQt6.QtWidgets import QLayout
 
-from .common import *
-from .common import (  # underscore names are not re-exported by "import *"
+from .common import (
     _,
     _logger,
+    BalPlugin,
+    Buttons,
+    EnterButton,
+    HelpButton,
+    PasswordDialog,
+    QComboBox,
+    QGridLayout,
+    QHBoxLayout,
+    QInputDialog,
+    QLabel,
+    QPushButton,
+    QTimer,
+    QVBoxLayout,
+    QWidget,
+    UserCancelled,
+    Willexecutors,
+    add_widget,
+    partial,
     read_QIcon_from_bytes,
+    read_QPixmap_from_bytes,
+    show_modal,
+    webopen,
 )
 from .dialogs import BalDialog
 from .widgets import BalCheckBox, BalLineEdit, BalSpinBox, BalTextEdit

bal/gui/qt/widgets.py

@@ -28,8 +28,53 @@ from ...core.input_rules import (
 )
 from ...core.reminders import build_ics_reminders, write_temp_ics
 from .calendar import BalCalendar, BalCalendarButton
-from .common import *
-from .common import _, _logger  # underscore names are not re-exported by "import *"
+from .common import (
+    _,
+    _logger,
+    Any,
+    BTCAmountEdit,
+    BalTimestamp,
+    ColorScheme,
+    DECIMAL_POINT,
+    Decimal,
+    HelpButton,
+    NLOCKTIME_BLOCKHEIGHT_MAX,
+    NLOCKTIME_MAX,
+    Optional,
+    QAbstractSpinBox,
+    QCheckBox,
+    QColor,
+    QComboBox,
+    QDateTime,
+    QDateTimeEdit,
+    QHBoxLayout,
+    QLabel,
+    QLineEdit,
+    QPainter,
+    QPalette,
+    QPushButton,
+    QSizePolicy,
+    QSpinBox,
+    QStyle,
+    QStyleOptionFrame,
+    QTextEdit,
+    QVBoxLayout,
+    QWidget,
+    Qt,
+    Union,
+    Util,
+    Will,
+    char_width_in_lineedit,
+    datetime,
+    getSaveFileName,
+    log_error,
+    os,
+    partial,
+    pyqtSignal,
+    read_QIcon_from_bytes,
+    signature_suffix,
+    status_color,
+)
 
 if TYPE_CHECKING:
     from .window import BalWindow

bal/gui/qt/window.py

@@ -24,8 +24,63 @@ from ...core.checkalive import (
     check_alive_expired,
     resolve_date_to_check,
 )
-from .common import *
-from .common import _, _logger  # underscore names are not re-exported by "import *"
+from .common import (
+    _,
+    _logger,
+    AmountException,
+    BalPlugin,
+    Buttons,
+    CancelButton,
+    ElectrumWindow,
+    FileImportFailed,
+    HeirChangeException,
+    HeirNotFoundException,
+    Heirs,
+    HelpButton,
+    Mapping,
+    Network,
+    NoHeirsException,
+    NoWillExecutorNotPresent,
+    NotCompleteWillException,
+    OP_RETURN_PREFIX,
+    OkButton,
+    PaymentIdentifier,
+    QGridLayout,
+    QLabel,
+    QLineEdit,
+    QPushButton,
+    QTimer,
+    QVBoxLayout,
+    SerializationError,
+    Transaction,
+    TxDialog,
+    TxFeesChangedException,
+    Util,
+    Will,
+    WillExecutorFeeTooHighException,
+    WillExecutorNotPresent,
+    WillExpiredException,
+    WillItem,
+    WillPostponedException,
+    WillexecutorChangeException,
+    Willexecutors,
+    char_width_in_lineedit,
+    copy,
+    export_meta_gui,
+    import_meta_gui,
+    is_onion_url,
+    is_op_return_address,
+    is_tor_active,
+    log_error,
+    partial,
+    read_QIcon_from_bytes,
+    read_json_file,
+    show_on_top,
+    shown_cv,
+    time,
+    tx_from_any,
+    write_json_file,
+)
 from .dialogs import (
     BalBuildWillDialog,
     BalDialog,