UI polish and signed-tx colour fix (v0.3.3)
Fix and refine the BAL plugin GUI without changing business logic: core/will.py: restore the PUSHED requirement in needs_server_check so a signed-but-not-broadcast will is no longer server-queried and therefore stays blue (COMPLETE) instead of turning red (CHECK_FAIL). This matches the original Gitea check() condition. gui/qt/widgets.py: WillSettingsWidget vertical layout now caps every row to the widest date-row width and left-aligns them; the leading icons keep their original HelpButton width. gui/qt/lists.py + gui/qt/common.py: the wizard toolbar button now shows a 28x28 icon plus a bold 'Create your will' caption (QSize imported). gui/qt/dialogs.py (BalBuildWillDialog): - closing summary row labelled 'All done: Ok' with a blank separator above it; - 'checking variables' capitalised to 'Checking variables' (redundant trailing colon dropped); - final auto-closing countdown replaced by an explicit right-aligned 'Close' button; intermediate technical pauses kept; next-steps popup preserved. gui/qt/window.py + core/plugin_base.py: guide show_message on build, and sync_hide_filters() in update_all so hide flags refresh immediately. tests: test_needs_server_check updated; added offscreen preview helpers. Version bumped to 0.3.3. 186 tests pass; ruff clean (baseline only).
This commit is contained in:
committed by
steal
parent
365824767b
commit
30bab62247
@@ -88,17 +88,20 @@ class Will:
|
||||
"""Return True if ``w`` should be queried on its will-executor server
|
||||
when the user presses Check (or on Electrum close).
|
||||
|
||||
A will needs a server check when it is VALID, has a will-executor
|
||||
assigned, and is not yet CHECKED. This intentionally includes wills
|
||||
that are not (yet) marked PUSHED: a will that was actually sent in the
|
||||
past but whose saved status still reads "New" would otherwise be
|
||||
skipped, leaving the Server column stuck on "Not sent". The server
|
||||
response (see WillItem.set_check_willexecutor) then corrects the status
|
||||
to PUSHED/CHECKED if the transaction is present, or CHECK_FAIL if not.
|
||||
A will is queried only when it is VALID, has a will-executor assigned,
|
||||
was actually PUSHED (sent), and is not yet CHECKED. The ``PUSHED``
|
||||
condition is essential: querying the server for a will that was *never*
|
||||
sent would make the server (correctly) answer "I don't have this tx",
|
||||
which ``WillItem.set_check_willexecutor`` then records as CHECK_FAIL.
|
||||
A freshly signed-but-not-sent will would therefore turn red, even though
|
||||
it is merely "signed, not sent" (which must stay blue / #2bc8ed, as in
|
||||
the original BAL behaviour). Restricting the check to PUSHED wills
|
||||
matches the original ``check()`` logic and avoids that false failure.
|
||||
"""
|
||||
return bool(
|
||||
w.get_status("VALID")
|
||||
and w.we
|
||||
and w.get_status("PUSHED")
|
||||
and not w.get_status("CHECKED")
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user